Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 96EFA906F for ; Tue, 6 Mar 2012 15:32:21 +0000 (UTC) Received: (qmail 38395 invoked by uid 500); 6 Mar 2012 15:32:21 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 38373 invoked by uid 500); 6 Mar 2012 15:32:21 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 38365 invoked by uid 99); 6 Mar 2012 15:32:21 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Mar 2012 15:32:21 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Mar 2012 15:32:18 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id BDA96B7FB for ; Tue, 6 Mar 2012 15:31:57 +0000 (UTC) Date: Tue, 6 Mar 2012 15:31:57 +0000 (UTC) From: "Kristian Waagan (Commented) (JIRA)" To: derby-dev@db.apache.org Message-ID: <1693086250.27665.1331047917778.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (DERBY-2031) Convert derbynet/testProtocol.java to JUnit MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223327#comment-13223327 ] Kristian Waagan commented on DERBY-2031: ---------------------------------------- Disabled test with revision 1297524 while investigating a permission issue. > Convert derbynet/testProtocol.java to JUnit > ------------------------------------------- > > Key: DERBY-2031 > URL: https://issues.apache.org/jira/browse/DERBY-2031 > Project: Derby > Issue Type: Improvement > Components: Network Server, Test > Affects Versions: 10.3.1.4 > Reporter: Knut Anders Hatlen > Assignee: Kristian Waagan > Priority: Minor > Fix For: 10.9.0.0 > > Attachments: d2031.diff, d2031.stat, derby-2031-1a-grammar_enum.diff, derby-2031-1a-grammar_enum.stat, derby-2031-2a-test.diff, derby-2031-3a-enable_test.diff, derby-2031-3a-enable_test.stat, derby-2031-3b-enable_test.diff, derby-2031-4a-close_streams.diff, derby-2031-5a-new_adapter.diff, derby-2031-5a-new_adapter.stat, derby-2031-5b-new_adapter.diff, derby-2031-pre_with_git.diff, derby-2031-pre_with_git.stat > > > testProtocol.java executes DRDA commands from a file written in a special-purpose language. The statements are very much like assertions, so it should be fairly easy to convert the test to JUnit. > Suggested approach: Change the interpreter (TestProto.java) so that is uses Assert.fail() instead of System.err.println() and System.exit(), and BaseTestCase.println() instead of System.out.println(). It should also use TestConfiguration to get the host name and port number. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira