db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5641) Remove unused BaseDataFileFactory methods plus minor cleanups
Date Wed, 07 Mar 2012 13:50:57 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224335#comment-13224335
] 

Knut Anders Hatlen commented on DERBY-5641:
-------------------------------------------

Looks like a good cleanup. +1
                
> Remove unused BaseDataFileFactory methods plus minor cleanups
> -------------------------------------------------------------
>
>                 Key: DERBY-5641
>                 URL: https://issues.apache.org/jira/browse/DERBY-5641
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>    Affects Versions: 10.9.0.0
>            Reporter: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-5641-1a-unused_methods_plus_cleanup.diff
>
>
> BaseDataFileFactory has some unused methods, they can be removed: syncSideLog, pageToDirty
and getTempDirectory
> In addition I suggest the following cleanups:
>  o remove unused imports
>  o remove unnecessary return statement
>  o make synchronization object freezeSemaphore final
>  o remove unused instance variable backupPath
>  o remove unused local variable (and exception instantiation) multipleJBMSWarning
>  o replace new Boolean with Boolean.valueOf

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message