db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5631) Extend SecurityManagerSetup to add extra privileges to the set of default privileges (merge two policy files)
Date Thu, 01 Mar 2012 01:33:58 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219707#comment-13219707

Dag H. Wanvik commented on DERBY-5631:

Patch 1b looks good to me. I have one more small nit: I'd prefer the test on policy2 == null
to be outside of mergePolicies, since in that case no merging takes place making the name
of the method a bit misleading. Alternately, change the name to cater for both one and two
policies, e.g. "getEffectivePolicyResourceString". Up to you, +1 in any case.

> Extend SecurityManagerSetup to add extra privileges to the set of default privileges
(merge two policy files)
> -------------------------------------------------------------------------------------------------------------
>                 Key: DERBY-5631
>                 URL: https://issues.apache.org/jira/browse/DERBY-5631
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions:
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>         Attachments: derby-5631-1a-merge_policy_files.diff, derby-5631-1b-merge_policy_files.diff,
> When moving ProtocolTest into suites all (see DERBY-2031), I needed to allow the test
code to create a socket. There was already a policy file for the old harness for doing this,
but when using this with the JUnit framework I ended up adding privilege after privilege to
get the framework itself running.
> Instead of creating a large policy file duplicating all the privileges that the framework
requires to function properly, I think it would be better to make the SecurityManagerSetup
capable of merging the test specific policy file with the default policy file.
> This mode of operation can be used when you need a few extra privileges to execute the
test, but there are probably also tests where you want full control of the privileges - in
which case you use the existing mode of operation.
> I'm not 100% sure this approach will always work, but basic testing has shown promising

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message