db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-2031) Convert derbynet/testProtocol.java to JUnit
Date Tue, 13 Mar 2012 18:50:40 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kristian Waagan updated DERBY-2031:
-----------------------------------

    Attachment: derby-2031-6a-pptesting_removal.stat
                derby-2031-6a-pptesting_removal.diff

The new test seems to be running without failures. I'll soon remove the old style harness
version of the test and the assoicated support files.

Attaching patch 6a, which removes the package-private version of the test.
The number of tests in 'ant junit-pptesting' went down from 222 to 67 after removing ProtocolTest.
This fits nicely, as that test has 155 test cases.

Committed patch 6a to trunk with revision 1300285.
                
> Convert derbynet/testProtocol.java to JUnit
> -------------------------------------------
>
>                 Key: DERBY-2031
>                 URL: https://issues.apache.org/jira/browse/DERBY-2031
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server, Test
>    Affects Versions: 10.3.1.4
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.9.0.0
>
>         Attachments: d2031.diff, d2031.stat, derby-2031-1a-grammar_enum.diff, derby-2031-1a-grammar_enum.stat,
derby-2031-2a-test.diff, derby-2031-3a-enable_test.diff, derby-2031-3a-enable_test.stat, derby-2031-3b-enable_test.diff,
derby-2031-4a-close_streams.diff, derby-2031-5a-new_adapter.diff, derby-2031-5a-new_adapter.stat,
derby-2031-5b-new_adapter.diff, derby-2031-6a-pptesting_removal.diff, derby-2031-6a-pptesting_removal.stat,
derby-2031-pre_with_git.diff, derby-2031-pre_with_git.stat
>
>
> testProtocol.java executes DRDA commands from a file written in a special-purpose language.
The statements are very much like assertions, so it should be fairly easy to convert the test
to JUnit.
> Suggested approach: Change the interpreter (TestProto.java) so that is uses Assert.fail()
instead of System.err.println() and System.exit(), and BaseTestCase.println() instead of System.out.println().
It should also use TestConfiguration to get the host name and port number.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message