db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-5639) Minor code cleanup for NetServlet
Date Mon, 05 Mar 2012 13:59:58 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Kristian Waagan updated DERBY-5639:

    Attachment: derby-5639-2a-misc.stat

Attaching patch 2a, containing minor code cleanups.
Most notably: 
 o made 'Runnable service' local (was instance variable)
 o removed three unused messages (also from the resource bundle files, i.e. servlet_LANG.properties)
 o made getHtmlLabelledMessageInstance private
 o removed a bunch of unused local variable initialization values

Patch ready for review.
> Minor code cleanup for NetServlet
> ---------------------------------
>                 Key: DERBY-5639
>                 URL: https://issues.apache.org/jira/browse/DERBY-5639
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Miscellaneous, Network Server, Tools
>    Affects Versions:
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-5639-1a-remove_request_param.diff, derby-5639-2a-misc.diff,
> The code in NetServlet has a few quality issues, some of which are easily addressed.
I plan to address the easy ones here, the main one will be removing unused variables.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message