Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Fri, 17 Feb 2012 14:05:59 +0000 (UTC)
From: "Kristian Waagan (Updated) (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: 
 <1390345340.50720.1329487559672.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1850154434.50645.1329486600132.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (DERBY-5620) Replace illegal characters from test
 name when creating the failure folder
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DERBY-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-5620:
-----------------------------------

    Attachment: derby-5620-1a-replace_illegal_fs_chars.diff

Attaching patch 1a, which replaces a set of characters from the string returned by TestCase.getName().

I suspect the list isn't exhaustive, but it may already include characters that are allowed in some file system. The point here is just to make sure the directory creation works. In my case it failed due to putting '<>' in a test name (compatibility test).
More characters that should go in?
Is there perhaps a method in the Java-API that will remove illegal chars?

Patch ready for review.
                
> Replace illegal characters from test name when creating the failure folder
> --------------------------------------------------------------------------
>
>                 Key: DERBY-5620
>                 URL: https://issues.apache.org/jira/browse/DERBY-5620
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.9.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-5620-1a-replace_illegal_fs_chars.diff
>
>
> Since the name of a JUnit test case can be any string, it should be sanitized and bad characters should be replaced with a valid one.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira