Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Tue, 21 Feb 2012 08:14:34 +0000 (UTC)
From: "Kristian Waagan (Updated) (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: 
 <1011214566.5076.1329812074996.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1017145374.40142.1329303659919.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (DERBY-5617) Improve process handling in
 SpawnedProcess
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DERBY-5617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-5617:
-----------------------------------

    Attachment: derby-5617-2a-join_destroy_ordering.diff

Attaching patch 2a.

Thanks, Myrna.
I have messed up the order in which the process is cleaned up, which includes closing the streams assoicated with the process, and waiting for the output drainer streams to terminate. On some machines this causes truncated output (scheduler/timing/performance issue), and in any case the ordering is incorrect.

Fixed with patch 2a, which also takes care of a few typos. Committed to trunk with revision 1291631.
                
> Improve process handling in SpawnedProcess
> ------------------------------------------
>
>                 Key: DERBY-5617
>                 URL: https://issues.apache.org/jira/browse/DERBY-5617
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.9.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.9.0.0
>
>         Attachments: derby-5617-1a-spawnedprocess_improvements.diff, derby-5617-2a-join_destroy_ordering.diff
>
>
> SpawnedProcess wraps a java.lang.Process and performs various tasks related to process handling. Using external processes from Java is somewhat tricky, in part because of sub-optimal behavior in the methods provided by Process.
> I plan to implement the following improvements:
>  a) Kill the process after a timeout (the clock starts ticking when you create the SpawnedProcess instance).
>  b) Don't let interrupts stop SpawnedProcess from waiting for / terminating the process.
>  c) Clean up the Process properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira