db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-5561) Race conditions in LogicalConnection checking for a null physical connection
Date Fri, 17 Feb 2012 18:37:59 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kathey Marsden updated DERBY-5561:
----------------------------------

    Issue & fix info: High Value Fix,Patch Available
             Urgency: Urgent
              Labels: derby_triage10_9  (was: )

Triage for 10.9.  Urgent, High Value Fix. Thanks Brett for the patch and Siddharth for picking
up the testing and driving it to commit.

                
> Race conditions in LogicalConnection checking for a null physical connection
> ----------------------------------------------------------------------------
>
>                 Key: DERBY-5561
>                 URL: https://issues.apache.org/jira/browse/DERBY-5561
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client
>    Affects Versions: 10.8.2.2
>         Environment: Solaris 10
> Glassfish V2.1.1
> ClientXADataSource connection pool
>            Reporter: Brett Bergquist
>            Assignee: Siddharth Srivastava
>              Labels: derby_triage10_9
>         Attachments: DERBY-5561.patch
>
>
> There are race conditions with checkForNullPhysicalConnection calls in LogicalConnection.
 checkForNullPhysicalConnection is not synchronized and it checks for the member "phsyicalConnection"
which can be cleared by "nullPhsyicalConnection" (which is synchronized) and "close" (which
is synchronized) and "closeWithoutRecyclingToPool" (which is synchronized).
> This affects "nativeSQL", "getAutoCommit", "getTransactionIsolation", "getWarnings",
"isReadOnly", "getCatalog", "getTypeMap", "createStatement", "prepareCall", "prepareStatement",
"setHoldability", "getHoldability", "setSavePoint", "rollBack", "releaseSavePoint", "getSchema",
"setSchema".
> All of these call "checkForNullPhysicalConnection" and then use the member "physicalConnection"
after that call returns.  Because these methods are not synchronized, between the time "checkForNullPhysicalConnectoin"
returns and "physicalConnection" is used, the "physicalConnection" member could be set to
null and then a NPE occurs.
> Probably all of these methods should be changed to synchronized.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message