db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5604) [patch] access static constants with static references
Date Tue, 07 Feb 2012 03:21:07 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202044#comment-13202044
] 

Dag H. Wanvik commented on DERBY-5604:
--------------------------------------

Thanks, Dave. I noticed the following comment in the code for the declaration of BTree#maxRowsPerPage:

    RESOLVE (mikem) - this should not be static.  Need to design a way in
    debugging mode to get btree created with a persistent "maxRowsPerPage".
    This hack makes all btrees get created with the "last" maxRowsPerPage 
    value set.

so that may be why the access pattern is the way it is. Mike, do you think the access code
in  LeafControlRow should be changed to reflect reality, or would you want to keep it the
way it is until this gets resolved? It wouldn't do any hard to change it, were it changed
to be  a state variable, the compiler would flag the access via class.

                
> [patch] access static constants with static references
> ------------------------------------------------------
>
>                 Key: DERBY-5604
>                 URL: https://issues.apache.org/jira/browse/DERBY-5604
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>    Affects Versions: 10.8.2.2
>            Reporter: Dave Brosius
>            Priority: Trivial
>         Attachments: use_static_reference.diff
>
>
> code access static fields by fetching instances and getting the static variable from
the object. Just use the class reference.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message