Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BBF707E37 for ; Thu, 15 Dec 2011 23:24:02 +0000 (UTC) Received: (qmail 55158 invoked by uid 500); 15 Dec 2011 23:24:02 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 55133 invoked by uid 500); 15 Dec 2011 23:24:02 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 55126 invoked by uid 99); 15 Dec 2011 23:24:02 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Dec 2011 23:24:02 +0000 X-ASF-Spam-Status: No, hits=-2001.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Dec 2011 23:23:52 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 9652F1156F0 for ; Thu, 15 Dec 2011 23:23:30 +0000 (UTC) Date: Thu, 15 Dec 2011 23:23:30 +0000 (UTC) From: "Dag H. Wanvik (Commented) (JIRA)" To: derby-dev@db.apache.org Message-ID: <369416681.17482.1323991410617.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <102801960.15219.1323952951260.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (DERBY-5541) Remove unnecessary field rwsOK in DirStorageFactory4 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170569#comment-13170569 ] Dag H. Wanvik commented on DERBY-5541: -------------------------------------- The changes look good to me. +1 > Remove unnecessary field rwsOK in DirStorageFactory4 > ---------------------------------------------------- > > Key: DERBY-5541 > URL: https://issues.apache.org/jira/browse/DERBY-5541 > Project: Derby > Issue Type: Improvement > Components: Store > Affects Versions: 10.9.0.0 > Reporter: Knut Anders Hatlen > Assignee: Knut Anders Hatlen > Priority: Minor > Attachments: d5541.diff > > > DirStorageFactory4 has a field called rwsOK defined like this: > private static final boolean rwsOK = JVMInfo.JDK_ID >= JVMInfo.J2SE_142; > The only supported platform whose JVMInfo.JDK_ID is less than JVMInfo.J2SE_142, is FP/CDC. But DirStorageFactory4 is not used on FP/CDC because it depends on NIO. This means that the field will always have the value true, and it can be eliminated. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira