From derby-dev-return-92102-apmail-db-derby-dev-archive=db.apache.org@db.apache.org Mon Dec 5 17:33:05 2011 Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 028F37220 for ; Mon, 5 Dec 2011 17:33:05 +0000 (UTC) Received: (qmail 97555 invoked by uid 500); 5 Dec 2011 17:33:04 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 97514 invoked by uid 500); 5 Dec 2011 17:33:04 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 97390 invoked by uid 99); 5 Dec 2011 17:33:04 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Dec 2011 17:33:04 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Dec 2011 17:33:02 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 47EA1C60DB for ; Mon, 5 Dec 2011 17:32:41 +0000 (UTC) Date: Mon, 5 Dec 2011 17:32:41 +0000 (UTC) From: "Dag H. Wanvik (Assigned) (JIRA)" To: derby-dev@db.apache.org Message-ID: <1757869003.41589.1323106361296.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <540461661.41521.1323103720144.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Assigned] (DERBY-5521) JDBCMBeanTest#testAttributeDriverLevel uses Java assert in lieu of JUnit assert: no real testing happens MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dag H. Wanvik reassigned DERBY-5521: ------------------------------------ Assignee: Dag H. Wanvik > JDBCMBeanTest#testAttributeDriverLevel uses Java assert in lieu of JUnit assert: no real testing happens > -------------------------------------------------------------------------------------------------------- > > Key: DERBY-5521 > URL: https://issues.apache.org/jira/browse/DERBY-5521 > Project: Derby > Issue Type: Bug > Components: Test > Reporter: Dag H. Wanvik > Assignee: Dag H. Wanvik > Priority: Minor > Attachments: derby-5521.diff > > > Cf these lines: > assert(driverLevelString.indexOf('?') == -1); > assert(driverLevelString.matches("^JRE - JDBC: " + JDBCVersion + ".*")); > The "assert" is a Java built-in rather than the JUnit assertTrue we need. > The string driverLevelString is also wrong, since it is a mere toString of the bean name. We need to use getAttribute on it to get the driver level > for asserting. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira