db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5521) JDBCMBeanTest#testAttributeDriverLevel uses Java assert in lieu of JUnit assert: no real testing happens
Date Wed, 07 Dec 2011 01:52:40 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164055#comment-13164055
] 

Dag H. Wanvik commented on DERBY-5521:
--------------------------------------

Not suitable for backport, bug introduced post 10.8, closing.
                
> JDBCMBeanTest#testAttributeDriverLevel uses Java assert in lieu of JUnit assert: no real
testing happens
> --------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-5521
>                 URL: https://issues.apache.org/jira/browse/DERBY-5521
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>            Priority: Minor
>             Fix For: 10.9.0.0
>
>         Attachments: derby-5521.diff, derby-5521b.diff
>
>
> Cf these lines:
> assert(driverLevelString.indexOf('?') == -1);
> assert(driverLevelString.matches("^JRE - JDBC: " + JDBCVersion + ".*"));
> The "assert" is a Java built-in rather than the JUnit assertTrue we need.
> The string driverLevelString is also wrong, since it is a mere toString of the bean name.
We need to use getAttribute on it to get the driver level
> for asserting.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message