db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5541) Remove unnecessary field rwsOK in DirStorageFactory4
Date Thu, 15 Dec 2011 23:23:30 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170569#comment-13170569
] 

Dag H. Wanvik commented on DERBY-5541:
--------------------------------------

The changes look good to me. +1

                
> Remove unnecessary field rwsOK in DirStorageFactory4
> ----------------------------------------------------
>
>                 Key: DERBY-5541
>                 URL: https://issues.apache.org/jira/browse/DERBY-5541
>             Project: Derby
>          Issue Type: Improvement
>          Components: Store
>    Affects Versions: 10.9.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d5541.diff
>
>
> DirStorageFactory4 has a field called rwsOK defined like this:
>     private static final boolean    rwsOK = JVMInfo.JDK_ID >= JVMInfo.J2SE_142;
> The only supported platform whose JVMInfo.JDK_ID is less than JVMInfo.J2SE_142, is FP/CDC.
But DirStorageFactory4 is not used on FP/CDC because it depends on NIO. This means that the
field will always have the value true, and it can be eliminated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message