Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7C447988A for ; Fri, 4 Nov 2011 12:15:23 +0000 (UTC) Received: (qmail 43037 invoked by uid 500); 4 Nov 2011 12:15:23 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 43012 invoked by uid 500); 4 Nov 2011 12:15:23 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 43005 invoked by uid 99); 4 Nov 2011 12:15:23 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Nov 2011 12:15:23 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Nov 2011 12:15:20 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 03BA9332041 for ; Fri, 4 Nov 2011 12:15:00 +0000 (UTC) Date: Fri, 4 Nov 2011 12:15:00 +0000 (UTC) From: "Rick Hillegas (Commented) (JIRA)" To: derby-dev@db.apache.org Message-ID: <2138665347.726.1320408900016.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <434684097.19500.1319653052372.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (DERBY-5486) Upgrade tests should verify that DERBY-4437 was backed out of 10.8.2.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143945#comment-13143945 ] Rick Hillegas commented on DERBY-5486: -------------------------------------- Hi Knut, Yes, I think that is the case. Thanks. > Upgrade tests should verify that DERBY-4437 was backed out of 10.8.2.2 > ---------------------------------------------------------------------- > > Key: DERBY-5486 > URL: https://issues.apache.org/jira/browse/DERBY-5486 > Project: Derby > Issue Type: Improvement > Components: SQL, Test > Reporter: Rick Hillegas > Assignee: Rick Hillegas > Attachments: derby-5486-01-ab-mergeFiles.diff, derby-5486-02-aa-removeTests.diff > > > The following code in UpgradeRun needs to be reworked to verify that sequence/identities behave as expected when upgrading from 10.8.2.2: > if ( lessThan( version, new int[] { 10, 8, 1, 6 } ) ) > { suite.addTest(Changes10_8_2.suite(phase)); } > The following might do the trick: > if (oldMinor < 7) > suite.addTest(Changes10_7.suite(phase)); > if (oldMinor < 9) > { > suite.addTest(Changes10_9.suite(phase)); > suite.addTest(Changes10_8_2.suite(phase)); > } > Thanks to Kristian for spotting this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira