db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5469) Make it possible to build Derby if you are on Mac OS X and your JDK is JDK 7
Date Tue, 25 Oct 2011 13:54:32 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135067#comment-13135067
] 

Kristian Waagan commented on DERBY-5469:
----------------------------------------

Thanks for the updated patch, Rick.

Unfortunately, the comments for the names/seeds are now inaccurate, as the values aren't used
as directory name seeds by the setForXXXJARInspection methods. The way I understand it, the
seed is used as a directory name seed with the directory-based algorithm, and as a specification
version seed with the JAR-inspection-based algorithm. This is only relevant for the variables
'_oracleDirectoryNameSeed' and '_ibmDirectoryNameSeed'. '_ibmDirectoryNameSeedWithoutPeriod'
is only used by the directory-based algorithm and is correct as it stands.
Not sure what to suggest, besides from either making these two names less specific again or
creating two methods with different names returning the same value...

Maybe it's not so important either, I'll let you decide.

There's no comment about the tool setting 'java17compile.classpath'. Is that correct, or just
an omission?
                
> Make it possible to build Derby if you are on Mac OS X and your JDK is JDK 7
> ----------------------------------------------------------------------------
>
>                 Key: DERBY-5469
>                 URL: https://issues.apache.org/jira/browse/DERBY-5469
>             Project: Derby
>          Issue Type: Improvement
>          Components: Build tools
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>         Attachments: derby-5469-01-ae-add17andJavadoc.diff, derby-5469-01-af-dontSetUprevVariables.diff,
derby-5469-01-ag-cleanedUp.diff
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message