db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5300) Change derby.tests.trace to print the class as well as fixture name
Date Wed, 12 Oct 2011 08:43:12 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125667#comment-13125667
] 

Kristian Waagan commented on DERBY-5300:
----------------------------------------

I already commented on that patch (see comment from 05/Sep/11 10:17).
There are two issues with it that must be fixed:
 o a missing dot between the class name and the fixture/method name:
    (emb)lang.CollationTest2testDefaultCollation
    
 o it assumes the prefix is always present, which isn't the case:
    java ... junit.textui.TestRunner org.apache.derbyTesting.unitTests.junit._Suite
    (emb)ayInputStreamTesttestSkipLongMaxValue used 441 ms .
    (emb)ayInputStreamTesttestSkipBytesIntMaxValue used 0 ms .
    (emb)ayInputStreamTesttestSkipNegative used 0 ms .
    (emb)ayInputStreamTesttestSkipBytesNegative used 0 ms .
    (emb)matableBitSetTesttestSetup used 61 ms .
    (emb)matableBitSetTesttestIntCtor0 used 0 ms .
    (emb)matableBitSetTesttestIntCtor1 used 0 ms .

I don't know if it's worth it, but we could consider doing the shortening in steps:
 a) Check if the prefix is 'org.apache.derbyTesting.functionTests.tests.'
 b) Check if the prefix is 'org.apache.derbyTesting.'
 c) Otherwise use fully qualified class name.


Thanks,
                
> Change derby.tests.trace to print the class as well as fixture name
> -------------------------------------------------------------------
>
>                 Key: DERBY-5300
>                 URL: https://issues.apache.org/jira/browse/DERBY-5300
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.9.0.0
>            Reporter: Kathey Marsden
>            Assignee: Jayaram Subramanian
>            Priority: Trivial
>         Attachments: classinfixture_Aug182011.txt, derby-5300-1a-print_jdbc_client.diff,
svnstat-classinfixture.txt
>
>
> I was thinking it would be good for the test output with -Dderby.tests.trace=true to
have the class name as well as the fixture as I think if I had a nickel  for every time I
grepped for a fixture name to find out what class it is in, I would have a pretty big piggy
bank.
> It could print the full class name, like this:
> org.apache.derbyTesting.functionTests.tests.lang.SimpleTest.testBasicOperations used
844 ms .
> or strip off the org.apache.derbyTesting.functionTests for less output like:
> tests.lang.SimpleTest.testBugFixes used 6265 ms .
> Any preferences?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message