db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-2720) remove dead code associated with unsupported National Char implementation
Date Mon, 10 Oct 2011 11:51:29 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kristian Waagan updated DERBY-2720:
-----------------------------------

    Attachment: derby-2720-2a-remove_getNationalString.diff

Attaching patch 2a, which removed the method DataType.getNationalString and its implementations.

Regression tests ran without failures.
Patch ready for review.

I plan to commit this patch shortly.
                
> remove dead code associated with unsupported National Char implementation
> -------------------------------------------------------------------------
>
>                 Key: DERBY-2720
>                 URL: https://issues.apache.org/jira/browse/DERBY-2720
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Mike Matrigali
>            Assignee: Mamta A. Satoor
>            Priority: Minor
>             Fix For: 10.3.3.1
>
>         Attachments: derby-2720-1a-remove_sqlchar_getXFormat.diff, derby-2720-2a-remove_getNationalString.diff
>
>
> Derby still has some untested, unused code relating to a non-standard implementation
of a Nationa Char type.  The current code can be removed.  
> I believe the interesting functionality associated with this is now provided by DERBY-1478
(territory based collation) .  If  Derby ever implements a
> National Char type it should do so differently than the existing code, collation should
not be tied to the National Char type.    
> I believe a future National char type might have to maintain a separate type id for compatibility
with jdbc interface, but actual implmentation should be
> the same code as the char types.  Collating of the the national char type should be supported
in exactly same way as regular char types.
> If anyone is really intested in the national char code, it's history will always be available
in svn, and a consistent version is available by looking at 10.0, 10.1,
> and 10.2 codelines.  I would propose any removal of code only take place in trunk and
not be backported to a released codeline.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message