db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5469) Make it possible to build Derby if you are on Mac OS X and your JDK is JDK 7
Date Mon, 24 Oct 2011 09:49:32 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133940#comment-13133940

Kristian Waagan commented on DERBY-5469:

I tested the patch on Windows Vista, and it works fine for me. Note that ant uses JAVA_HOME
to decide which version of Java is used to invoke ant, so one has to either unset it or point
it at the Java version one wants to use.

Javadocs built with both JDK 6 and 7.

A few comments on the changes in PropertySetter:
 o 141: JAVA_5 is unused.
 o 578: currentJDK is unused
 o 1302: printProperty is unused (used for debugging?)
 o 1525: requireProperty is unused

It would maybe be good to comment on the structure and methods of JDKVersion.
The variables 'baseJavaVersion', 'oracleName', 'ibmBaseName', and 'ibmLatestName' are not
immediately self-explaining to me. For instance, why are both 'baseJavaVersion' and 'oracleName'
needed? What's the difference between 'ibmBaseName' and 'ibmLatestName'?  It's also not clear
to me if name is another word for version, or if name is something else. Is 'baseJavaVersion'
the specification version of the JDK/JRE?
> Make it possible to build Derby if you are on Mac OS X and your JDK is JDK 7
> ----------------------------------------------------------------------------
>                 Key: DERBY-5469
>                 URL: https://issues.apache.org/jira/browse/DERBY-5469
>             Project: Derby
>          Issue Type: Improvement
>          Components: Build tools
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>         Attachments: derby-5469-01-ae-add17andJavadoc.diff, derby-5469-01-af-dontSetUprevVariables.diff

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message