Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CC29982F3 for ; Fri, 2 Sep 2011 00:56:34 +0000 (UTC) Received: (qmail 64637 invoked by uid 500); 2 Sep 2011 00:56:34 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 64600 invoked by uid 500); 2 Sep 2011 00:56:33 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 64587 invoked by uid 99); 2 Sep 2011 00:56:33 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Sep 2011 00:56:33 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Sep 2011 00:56:30 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id BD34737474 for ; Fri, 2 Sep 2011 00:56:09 +0000 (UTC) Date: Fri, 2 Sep 2011 00:56:09 +0000 (UTC) From: "Dag H. Wanvik (JIRA)" To: derby-dev@db.apache.org Message-ID: <875254598.8943.1314924969771.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <507378079.20088.1311980529620.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (DERBY-5363) Tighten default permissions of DB files with >= JDK6 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095696#comment-13095696 ] Dag H. Wanvik commented on DERBY-5363: -------------------------------------- Thanks for looking at the patch code, Knut. 1) Agreed, it's brittle. 2) Yes, I did consider that. It is probably more robust, so I like the idea, although it's slightly more code to perform for the Posix case. The upside is probably more important: I read somewhere a NFS share on Windows would have Posix permissions, and your solution might make it work correctly in such a case also. 3) I think it would mostly be single threaded, at least on a new database, but I don't think we have a guarantee, so I'll protect it. > Tighten default permissions of DB files with >= JDK6 > ---------------------------------------------------- > > Key: DERBY-5363 > URL: https://issues.apache.org/jira/browse/DERBY-5363 > Project: Derby > Issue Type: Improvement > Components: Miscellaneous, Services, Store > Reporter: Dag H. Wanvik > Assignee: Dag H. Wanvik > Attachments: derby-5363-basic-1.diff, derby-5363-basic-1.stat, derby-5363-basic-2.diff, derby-5363-basic-2.stat, permission-5.diff, permission-5.stat, permission-6.diff, permission-6.stat, property-table.png, z.sql > > > Before Java 6, files created by Derby would have the default > permissions of the operating system context. Under Unix, this would > depend on the effective umask of the process that started the Java VM. > In Java 6 and 7, there are methods available that allows tightening up this > (File.setReadable, setWritable), making it less likely that somebody > would accidentally run Derby with a too lenient default. > I suggest we take advantage of this, and let Derby by default (in Java > 6 and higher) limit the visibility to the OS user that starts the VM, > e.g. on Unix this would be equivalent to running with umask 0077. More > secure by default is good, I think. > We could have a flag, e.g. "derby.storage.useDefaultFilePermissions" > that when set to true, would give the old behavior. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira