Return-Path: 
 <derby-dev-return-90825-apmail-db-derby-dev-archive=db.apache.org@db.apache.org>
X-Original-To: apmail-db-derby-dev-archive@www.apache.org
Delivered-To: apmail-db-derby-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 7CBB4999E
	for <apmail-db-derby-dev-archive@www.apache.org>;
 Fri, 23 Sep 2011 08:28:51 +0000 (UTC)
Received: (qmail 17492 invoked by uid 500); 23 Sep 2011 08:28:51 -0000
Delivered-To: apmail-db-derby-dev-archive@db.apache.org
Received: (qmail 17461 invoked by uid 500); 23 Sep 2011 08:28:51 -0000
Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:derby-dev-help@db.apache.org>
List-Unsubscribe: <mailto:derby-dev-unsubscribe@db.apache.org>
List-Post: <mailto:derby-dev@db.apache.org>
List-Id: <derby-dev.db.apache.org>
Reply-To: <derby-dev@db.apache.org>
Delivered-To: mailing list derby-dev@db.apache.org
Received: (qmail 17441 invoked by uid 99); 23 Sep 2011 08:28:51 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Sep 2011 08:28:50 +0000
X-ASF-Spam-Status: No, hits=-2000.5 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Sep 2011 08:28:48 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 153A2AA7FC
	for <derby-dev@db.apache.org>; Fri, 23 Sep 2011 08:28:28 +0000 (UTC)
Date: Fri, 23 Sep 2011 08:28:28 +0000 (UTC)
From: "Knut Anders Hatlen (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: 
 <541980728.5634.1316766508083.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <107539446.43175.1316456348959.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (DERBY-5420) TableLockBasicTest is locale
 sensitive: failed with Norwegian locale on Windows.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/DERBY-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113254#comment-13113254 ] 

Knut Anders Hatlen commented on DERBY-5420:
-------------------------------------------

Just a thought... What if we change the message text of the RTS_OPT_EST_RC message in messages.xml from

    <text>optimizer estimated row count</text>
to
    <text>optimizer estimated row count: {0,number,###########0.00}</text>

and in RealBasicNoPutResultSetStatistics.dumpEstimatedCosts() from

				MessageService.getTextMessage(SQLState.RTS_OPT_EST_RC) +
					": " +
				formatDouble(optimizerEstimatedRowCount) + "\n" +
to
				MessageService.getTextMessage(SQLState.RTS_OPT_EST_RC, new Double(optimizerEstimatedRowCount)) + "\n" +
?

Similar changes would be needed for RTS_OPT_EST_COST too.

Then we avoid the need to explicitly create and cache a DecimalFormat instance, and the number will be formatted using the same locale as the rest of the message (the database locale). And we can remove the formatDouble() method, so we'll reduce the code size too.

> TableLockBasicTest is locale sensitive: failed with Norwegian locale on Windows.
> --------------------------------------------------------------------------------
>
>                 Key: DERBY-5420
>                 URL: https://issues.apache.org/jira/browse/DERBY-5420
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>         Environment: Windows Vista SP2, Norwegian locale, JDK 7.
>            Reporter: Dag H. Wanvik
>            Priority: Minor
>
> The execution plans are asserted in this test and I saw this diff:
> Expected:
>         :
> 	optimizer estimated row count:            6.00
> 	optimizer estimated cost:          100.40<
> Found:
>         :
>         optimizer estimated row count:            6,00
> 	optimizer estimated cost:          100,40<
> the latter using a decimal comma whereas a decimal point is expected.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira