Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Wed, 28 Sep 2011 13:11:46 +0000 (UTC)
From: "Rick Hillegas (Commented) (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: 
 <237238511.3650.1317215506147.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (DERBY-1046) JVMInfo is duplicated in
 derbyclient.jar
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116419#comment-13116419 ] 

Rick Hillegas commented on DERBY-1046:
--------------------------------------

Thanks for the patch, Kathey. Before applying it, I saw JVMInfo in the following jar files:

derby.jar
derbyclient.jar
derbytools.jar

After applying the patch, I see JVMInfo in the following jar files:

derby.jar
derbytools.jar

In all cases, JVMInfo appears in this directory:

org/apache/derby/iapi/services/info

So this patch achieves what this JIRA wants to accomplish. I believe that the presence of JVMInfo in derbytools.jar means that DERBY-5431 is still possible.

I would recommend the following improvement to this patch: The cloned code warns the user to propagate changes to JVMInfo as well. I think that there should be a similar warning in JVMInfo, advising people to propagate changes to org.apache.derby.impl.tools.sysinfo.Main.

Thanks,
-Rick

                
> JVMInfo is duplicated in derbyclient.jar
> ----------------------------------------
>
>                 Key: DERBY-1046
>                 URL: https://issues.apache.org/jira/browse/DERBY-1046
>             Project: Derby
>          Issue Type: Bug
>          Components: Build tools
>    Affects Versions: 10.2.1.6
>            Reporter: Knut Anders Hatlen
>            Assignee: Kathey Marsden
>            Priority: Minor
>             Fix For: 10.2.1.6
>
>         Attachments: derby-1046.diff, derby-1046_diff.txt
>
>
> The JVMInfo class is included twice in derbyclient.jar, as
> org.apache.derby.iapi.services.info.JVMInfo and
> org.apache.derby.shared.common.info.JVMInfo. The only one of them
> actually used by the client code is the one found in
> org.apache.derby.shared.common.info.
> org.apache.derby.iapi.services.info.JVMInfo is also included in
> derby.jar, so one could run into problems if the classpath contains
> derbyclient.jar and derby.jar with different versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira