db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5420) TableLockBasicTest is locale sensitive: failed with Norwegian locale on Windows.
Date Fri, 23 Sep 2011 08:00:28 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113234#comment-13113234
] 

Knut Anders Hatlen commented on DERBY-5420:
-------------------------------------------

I agree with Bryan that it sounds broken to cache the DecimalFormat in a static field. According
to DecimalFormat's javadoc, it's not thread safe without external synchronization, so each
result set needs to have its own instance.

Another question is whether the correct fix is to use the default locale, or (as suggested
by the comments in the code) the database locale. I lean towards the latter, as I think the
rest of the runtime statistics output is generated with that locale.

> TableLockBasicTest is locale sensitive: failed with Norwegian locale on Windows.
> --------------------------------------------------------------------------------
>
>                 Key: DERBY-5420
>                 URL: https://issues.apache.org/jira/browse/DERBY-5420
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>         Environment: Windows Vista SP2, Norwegian locale, JDK 7.
>            Reporter: Dag H. Wanvik
>            Priority: Minor
>
> The execution plans are asserted in this test and I saw this diff:
> Expected:
>         :
> 	optimizer estimated row count:            6.00
> 	optimizer estimated cost:          100.40<
> Found:
>         :
>         optimizer estimated row count:            6,00
> 	optimizer estimated cost:          100,40<
> the latter using a decimal comma whereas a decimal point is expected.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message