Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 341E67C56 for ; Wed, 10 Aug 2011 01:05:50 +0000 (UTC) Received: (qmail 38795 invoked by uid 500); 10 Aug 2011 01:05:50 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 38752 invoked by uid 500); 10 Aug 2011 01:05:49 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 38744 invoked by uid 99); 10 Aug 2011 01:05:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Aug 2011 01:05:48 +0000 X-ASF-Spam-Status: No, hits=-2000.8 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Aug 2011 01:05:47 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 18C26B2C34 for ; Wed, 10 Aug 2011 01:05:27 +0000 (UTC) Date: Wed, 10 Aug 2011 01:05:27 +0000 (UTC) From: "Myrna van Lunteren (JIRA)" To: derby-dev@db.apache.org Message-ID: <1865640399.22260.1312938327086.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <157800642.1283.1312289127743.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Reopened] (DERBY-5368) Convert tools/ij2.sql to junit MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DERBY-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Myrna van Lunteren reopened DERBY-5368: --------------------------------------- One of the premises for using a CanonTestCase (of which ScriptTestCase is a subclass) is that there is only one canon (master) file for a test. In the case of ij2, this was not true, there was ij2.out, but also j9_foundation/ij2.out. If I compare the two original canons (e.g. in the 10.8 branch) I get the following diff: -------- 168,169c168,169 < CONNECTION0 - jdbc:derby:wombat < WOMBAT* - jdbc:derby:wombat --- > CONNECTION0 > WOMBAT* 173,174c173,174 < CONNECTION0* - jdbc:derby:wombat < WOMBAT - jdbc:derby:wombat --- > CONNECTION0* > WOMBAT 179c179 < CONNECTION0 - jdbc:derby:wombat --- > CONNECTION0 183c183 < CONNECTION0* - jdbc:derby:wombat --- > CONNECTION0* -------- In other words, the section that does the testing of the ij.protocol property (the section starting with '-- show multiconnect ability') shows 'jdbc:derby:wombat for non-JSR169 jvms, but no such addition for JSR169/J2ME/Foundation. The j9_foundation/ij2.out file has not been removed, but the junit framework does not know what to do about it, and so, the converted test fails now with JSR169, even with the section from DERBY-5346 in it. I tried playing a bit with various settings, but really there's no way to make the test behave the same. The ij.protocol (and originally, ij.database setting, which has been lost in the conversion) really do not mean anything in the context of a dataSource. I think the best thing to do, is to split off the multiconnect section into a separate .sql script. I'm reopening this issue to address this. > Convert tools/ij2.sql to junit > ------------------------------ > > Key: DERBY-5368 > URL: https://issues.apache.org/jira/browse/DERBY-5368 > Project: Derby > Issue Type: Sub-task > Components: Test > Reporter: Houx Zhang > Assignee: Houx Zhang > Labels: gsoc2011 > Fix For: 10.9.0.0 > > Attachments: 5368-1.patch, 5368-1.stat > > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira