db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (DERBY-5368) Convert tools/ij2.sql to junit
Date Wed, 10 Aug 2011 01:05:27 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Myrna van Lunteren reopened DERBY-5368:
---------------------------------------


One of the premises for using a CanonTestCase (of which ScriptTestCase is a subclass) is that
there is only one canon (master) file for a test. In the case of ij2, this was not true, there
was ij2.out, but also j9_foundation/ij2.out. 

If I compare the two original canons (e.g. in the 10.8 branch) I get the following diff:
--------
168,169c168,169
< CONNECTION0 -         jdbc:derby:wombat
< WOMBAT* -     jdbc:derby:wombat
---
> CONNECTION0
> WOMBAT*
173,174c173,174
< CONNECTION0* -        jdbc:derby:wombat
< WOMBAT -      jdbc:derby:wombat
---
> CONNECTION0*
> WOMBAT
179c179
< CONNECTION0 -         jdbc:derby:wombat
---
> CONNECTION0
183c183
< CONNECTION0* -        jdbc:derby:wombat
---
> CONNECTION0*
--------

In other words, the section that does the testing of the ij.protocol property (the section
starting with '-- show multiconnect ability') shows 'jdbc:derby:wombat for non-JSR169 jvms,
but no such addition for JSR169/J2ME/Foundation.

The j9_foundation/ij2.out file has not been removed, but the junit framework does not know
what to do about it, and so, the converted test fails now with JSR169, even with the section
from DERBY-5346 in it.

I tried playing a bit with various settings, but really there's no way to make the test behave
the same. The ij.protocol (and originally, ij.database setting, which has been lost in the
conversion) really do not mean anything in the context of a dataSource. 
I think the best thing to do, is to split off the multiconnect section into a separate .sql
script.

I'm reopening this issue to address this.

> Convert tools/ij2.sql to junit
> ------------------------------
>
>                 Key: DERBY-5368
>                 URL: https://issues.apache.org/jira/browse/DERBY-5368
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>            Reporter: Houx Zhang
>            Assignee: Houx Zhang
>              Labels: gsoc2011
>             Fix For: 10.9.0.0
>
>         Attachments: 5368-1.patch, 5368-1.stat
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message