db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-1903) Convert largedata/LobLimits.java to junit
Date Thu, 21 Jul 2011 09:34:57 GMT

     [ https://issues.apache.org/jira/browse/DERBY-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Knut Anders Hatlen updated DERBY-1903:
--------------------------------------

    Attachment: use-helper-methods.diff

While I was at it, I made some changes to the test so that it uses more of the framework helper
methods. Then we don't need to pass the connection object as a parameter that many places,
and it also ensures that statements are closed.

Also, I made the test close result sets a couple of places where it was forgotten. And in
insertClob2() we open a FileReader inside a loop, possibly many times, but we only close one
of the readers. I moved the closing inside the loop to ensure that all the readers are closed.

Committed revision 1149090.

> Convert  largedata/LobLimits.java to junit
> ------------------------------------------
>
>                 Key: DERBY-1903
>                 URL: https://issues.apache.org/jira/browse/DERBY-1903
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>            Reporter: V.Narayanan
>            Assignee: Kathey Marsden
>            Priority: Minor
>              Labels: LOB
>         Attachments: DERBY-1903_liteToAllPackages_diff.txt, derby-1903_addsuites_diff.txt,
derby-1903_client_diff.txt, derby-1903_embeddedp1_diff.txt, forced-order.diff, use-helper-methods.diff
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message