db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5342) make ScriptTestCase support "ij.showNoCountForSelect" and "ij.showNoConnectionsAtStart"
Date Tue, 26 Jul 2011 14:35:09 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071121#comment-13071121
] 

Bryan Pendleton commented on DERBY-5342:
----------------------------------------

Perhaps the code in ScriptTestCase.java which sets the ij properties should be moved
from the ScriptTestCase constructor to ScriptTestCase.setUp()?

I.e., something like:

Index: java/testing/org/apache/derbyTesting/functionTests/util/ScriptTestCase.java
===================================================================
--- java/testing/org/apache/derbyTesting/functionTests/util/ScriptTestCase.java	(revision
1149636)
+++ java/testing/org/apache/derbyTesting/functionTests/util/ScriptTestCase.java	(working copy)
@@ -26,6 +26,7 @@
 import java.util.Locale;
 
 import org.apache.derby.iapi.tools.i18n.LocalizedResource;
+import org.apache.derbyTesting.junit.BaseTestCase;
 import org.apache.derbyTesting.junit.Derby;
 
 import junit.framework.Test;
@@ -215,6 +216,9 @@
             }
         });
 
+        BaseTestCase.setSystemProperty("ij.showNoConnectionsAtStart", "true");
+        BaseTestCase.setSystemProperty("ij.showNoCountForSelect", "true");
+
         // Reset IJ's locale to allow it to pick up the new locale from
         // the environment.
         LocalizedResource.resetLocalizedResourceCache();



> make ScriptTestCase support "ij.showNoCountForSelect" and "ij.showNoConnectionsAtStart"
> ---------------------------------------------------------------------------------------
>
>                 Key: DERBY-5342
>                 URL: https://issues.apache.org/jira/browse/DERBY-5342
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Houx Zhang
>            Assignee: Houx Zhang
>              Labels: gsoc2011
>         Attachments: 5342-1.patch, 5342-2.patch, 5342-2.stat, 5342-3.patch, 5342-3.stat,
5342-4-test.patch
>
>
> Now, ScriptTestCase doesn't support property "ij.showNoConnectionsAtStart" (do nothing
for it) and "ij.showNoCountForSelect"(it always works as "ij.showNoCountForSelect" = "flase").
> It will be better if the two properties be supported. To realise this, utilMain.goScript(Connection
conn, LocalizedInput in) should be changed. Besides, some subclasses of ScripTestCase will
be adapted accordingly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message