db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Houx Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-5342) make ScriptTestCase support "ij.showNoCountForSelect" and "ij.showNoConnectionsAtStart"
Date Tue, 26 Jul 2011 12:52:09 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Houx Zhang updated DERBY-5342:
------------------------------

    Attachment: 5342-4-test.patch

Hi, Bryan, I have located the problem, but didn't know how to resolve it.

In a complete testing, LocalizedAttributeScriptTest and LocalizedDisplayScriptTest failed
because of IjConnNameTest. I have added the two tests into tools._Suite.suite() to  make the
failures reoccur fast.

As shown in 5342-4-test.patch, after IjConnNameTest ran, LocalizedAttributeScriptTest and
LocalizedDisplayScriptTest   failed just because util.getSystemProperty("ij.showNoConnectionsAtStart")
 is false in utilMain.goScript(). 

Besides, with the patch below, everything runs well:

Index: java/testing/org/apache/derbyTesting/functionTests/tests/i18n/LocalizedAttributeScriptTest.java
===================================================================
--- java/testing/org/apache/derbyTesting/functionTests/tests/i18n/LocalizedAttributeScriptTest.java
(revision 1149133)
+++ java/testing/org/apache/derbyTesting/functionTests/tests/i18n/LocalizedAttributeScriptTest.java
(working copy)
@@ -106,6 +106,8 @@
 
         uiProps.put("derby.ui.locale","de_DE");
         uiProps.put("derby.ui.codeset","ISO-8859-1");
+        uiProps.put("ij.showNoConnectionsAtStart", "true");
+        uiProps.put("ij.showNoCountForSelect", "true");
         suite.addTest(new SystemPropertyTestSetup(
                 new LocalizedAttributeScriptTest("LocalizedConnectionAttribute"), uiProps));
         
Index: java/testing/org/apache/derbyTesting/functionTests/tests/i18n/LocalizedDisplayScriptTest.java
===================================================================
--- java/testing/org/apache/derbyTesting/functionTests/tests/i18n/LocalizedDisplayScriptTest.java
(revision 1149133)
+++ java/testing/org/apache/derbyTesting/functionTests/tests/i18n/LocalizedDisplayScriptTest.java
(working copy)
@@ -110,6 +110,8 @@
         Properties uiProps = new Properties();
         uiProps.put("derby.ui.locale","es_AR");
         uiProps.put("derby.ui.codeset","EUC_JP");
+        uiProps.put("ij.showNoConnectionsAtStart", "true");
+        uiProps.put("ij.showNoCountForSelect", "true");
         suite.addTest(new SystemPropertyTestSetup(
                 new LocalizedDisplayScriptTest("LocalizedDisplay"), uiProps));
         return getIJConfig(suite);

However, I think this is not the right way to the problem.

Now, I'm strange with why the two properties has been changed after IjConnNameTest ran.

> make ScriptTestCase support "ij.showNoCountForSelect" and "ij.showNoConnectionsAtStart"
> ---------------------------------------------------------------------------------------
>
>                 Key: DERBY-5342
>                 URL: https://issues.apache.org/jira/browse/DERBY-5342
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Houx Zhang
>            Assignee: Houx Zhang
>              Labels: gsoc2011
>         Attachments: 5342-1.patch, 5342-2.patch, 5342-2.stat, 5342-3.patch, 5342-3.stat,
5342-4-test.patch
>
>
> Now, ScriptTestCase doesn't support property "ij.showNoConnectionsAtStart" (do nothing
for it) and "ij.showNoCountForSelect"(it always works as "ij.showNoCountForSelect" = "flase").
> It will be better if the two properties be supported. To realise this, utilMain.goScript(Connection
conn, LocalizedInput in) should be changed. Besides, some subclasses of ScripTestCase will
be adapted accordingly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message