db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-1903) Convert largedata/LobLimits.java to junit
Date Fri, 22 Jul 2011 07:04:57 GMT

     [ https://issues.apache.org/jira/browse/DERBY-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Knut Anders Hatlen updated DERBY-1903:
--------------------------------------

    Attachment: close-stream.diff

The test failed on some of the Windows platforms. For example here:

http://dbtg.foundry.sun.com/derby/test/Daily/jvm1.6/testing/testlog/vista/1149242-suitesAll_diff.txt

1) LobLimitsTestjunit.framework.AssertionFailedError: Failed to delete 2 files (root=C:\cludev\jagtmp\autoderbyN_regression\suitesAll_7\log\extinout:
C:\cludev\jagtmp\autoderbyN_regression\suitesAll_7\log\extinout\byteLobLimits.dat (isDir=false,
canRead=true, canWrite=true, size=102400), C:\cludev\jagtmp\autoderbyN_regression\suitesAll_7\log\extinout
(isDir=true, canRead=true, canWrite=true, size=0)
2) LobLimitsTestjunit.framework.AssertionFailedError: Failed to delete 2 files (root=C:\cludev\jagtmp\autoderbyN_regression\suitesAll_7\log\extinout:
C:\cludev\jagtmp\autoderbyN_regression\suitesAll_7\log\extinout\byteLobLimits.dat (isDir=false,
canRead=true, canWrite=true, size=102400), C:\cludev\jagtmp\autoderbyN_regression\suitesAll_7\log\extinout
(isDir=true, canRead=true, canWrite=true, size=0)

I think the problem is that compareBlobToFile() doesn't close the FileInputStream it opens,
and thereby prevent the deletion of the file when the test is done.

The attached patch replaces the body of that method with a call to the helper method BaseTestCase.assertEquals(InputStream,InputStream),
which does essentially the same thing and additionally closes both the streams before returning.

Committed revision 1149482.

> Convert  largedata/LobLimits.java to junit
> ------------------------------------------
>
>                 Key: DERBY-1903
>                 URL: https://issues.apache.org/jira/browse/DERBY-1903
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>            Reporter: V.Narayanan
>            Assignee: Kathey Marsden
>            Priority: Minor
>              Labels: LOB
>         Attachments: DERBY-1903_liteToAllPackages_diff.txt, close-stream.diff, derby-1903_addsuites_diff.txt,
derby-1903_client_diff.txt, derby-1903_embeddedp1_diff.txt, forced-order.diff, use-helper-methods.diff
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message