db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5282) Convert store/RowLockBasic.sql to junit
Date Fri, 01 Jul 2011 01:26:28 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058173#comment-13058173
] 

Myrna van Lunteren commented on DERBY-5282:
-------------------------------------------

Dag commented (6/30/2011) on the commit of revision 1141368 - apparently replies on the commit
messages don't make it back into JIRA, so just for the record, here is that comment:
"I didn't follow this one, but I notice setUp and teardown do not call
super.setUp, super.tearDown respectively as per the idiom. Is there a
reason for this here?  Notably BaseJDBCTestCase#tearDown does some
cleaning up. It may not be required here, but it's generally good to
stick to the idiom."

Houx Zhang replied: "Yes, Dag. I agree with you, and will adopt it."

Looks like Bryan already added super.teardown with revision 1141769.


> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
>                 Key: DERBY-5282
>                 URL: https://issues.apache.org/jira/browse/DERBY-5282
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>            Reporter: Houx Zhang
>            Assignee: Houx Zhang
>              Labels: gsoc2011
>             Fix For: 10.9.0.0
>
>         Attachments: derby-5282-1.patch, derby-5282-1.state, derby-5282-2.patch, derby-5282-2.state,
derby-5282-3.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message