db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-5077) [patch] remove non productive instanceof checks
Date Tue, 05 Jul 2011 13:26:16 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kristian Waagan updated DERBY-5077:
-----------------------------------

    Attachment: derby-5077-1a-remove_useless_instanceofs.diff

Attaching patch 1a, which is the original patch with some additional changes:
 o removed one more instanceof in SubqueryNode
 o made checkColumnOrdering in MergeSort private and rewrote the comment. Still not sure if
checking if the column is null adds value, but keeping it is no big deal (the method is only
called from a sanity block)
 o merged two SanityManager.DEBUG blocks.

Running the tests, will commit if they pass.

> [patch] remove non productive instanceof checks
> -----------------------------------------------
>
>                 Key: DERBY-5077
>                 URL: https://issues.apache.org/jira/browse/DERBY-5077
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server
>    Affects Versions: 10.7.1.1
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: 10.8.1.6
>
>         Attachments: derby-5077-1a-remove_useless_instanceofs.diff, remove_useless_instanceofs.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> various places in code does instanceof checks where the outcome can be determined statically
to be always true or always false.
> removed these checks as they do nothing.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message