db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-5318) Use assertDirectoryDeleted in ReplicationRun and remove dead code
Date Thu, 07 Jul 2011 08:58:16 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kristian Waagan updated DERBY-5318:
-----------------------------------

    Attachment: derby-5318-1a-cleanup.diff

Attaching patch 1a, which makes use of BaseJDBCTestCase.assertDirectoryDeleted to make the
test fail if some of the files in the database directory can't be deleted. Note that the root
directory will now be deleted and recreated, whereas before the patch the files inside the
root directory were deleted.
Also removed dead code and pruned out some unused method arguments.

The replication test ran fine on Solaris 11, will test on Windows too.
Patch ready for review.

> Use assertDirectoryDeleted in ReplicationRun and remove dead code
> -----------------------------------------------------------------
>
>                 Key: DERBY-5318
>                 URL: https://issues.apache.org/jira/browse/DERBY-5318
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.9.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-5318-1a-cleanup.diff
>
>
> The error reporting in the replication test when deleting files to initialize the master/slave
is insufficient. A message is printed to the console, but the test continues to run. This
can cause the test to fail for what appears to be a different reason the left-over files.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message