Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3B41D636F for ; Thu, 30 Jun 2011 11:34:58 +0000 (UTC) Received: (qmail 62154 invoked by uid 500); 30 Jun 2011 11:34:56 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 61779 invoked by uid 500); 30 Jun 2011 11:34:51 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 61760 invoked by uid 99); 30 Jun 2011 11:34:49 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Jun 2011 11:34:49 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Jun 2011 11:34:48 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 6574143B040 for ; Thu, 30 Jun 2011 11:34:28 +0000 (UTC) Date: Thu, 30 Jun 2011 11:34:28 +0000 (UTC) From: "Dag H. Wanvik (JIRA)" To: derby-dev@db.apache.org Message-ID: <64740604.5199.1309433668412.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1916114897.1324.1309327530381.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (DERBY-5305) Convert store/updatelocks.sql to JUnit MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DERBY-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057763#comment-13057763 ] Dag H. Wanvik commented on DERBY-5305: -------------------------------------- Thanks for the comments, Knut. As for the commented out decorateSQL code, I was torn on whether to remove it or retain it since it was part of the original test (although unused), but kept it till review time so someone else could chime in on it... ;-) Now that you spotted it, I'm +1 to removing it unless someone closer to the original authorship of this test feels it should stay. > Convert store/updatelocks.sql to JUnit > -------------------------------------- > > Key: DERBY-5305 > URL: https://issues.apache.org/jira/browse/DERBY-5305 > Project: Derby > Issue Type: Improvement > Components: Test > Reporter: Dag H. Wanvik > Assignee: Dag H. Wanvik > Priority: Minor > Attachments: derby-5305-a.diff, derby-5305-a.stat > > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira