Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9A4714649 for ; Sun, 12 Jun 2011 04:34:17 +0000 (UTC) Received: (qmail 18037 invoked by uid 500); 12 Jun 2011 04:34:16 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 18017 invoked by uid 500); 12 Jun 2011 04:34:16 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 17472 invoked by uid 99); 12 Jun 2011 04:34:16 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Jun 2011 04:34:16 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Jun 2011 04:34:13 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id E9A55414623 for ; Sun, 12 Jun 2011 04:33:52 +0000 (UTC) Date: Sun, 12 Jun 2011 04:33:52 +0000 (UTC) From: "Dag H. Wanvik (JIRA)" To: derby-dev@db.apache.org Message-ID: <1843116729.308.1307853232953.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <416623696.53963.1306782587371.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (DERBY-5253) Engine code references org.apache.derby.shared.common.sanity.SanityManager MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048227#comment-13048227 ] Dag H. Wanvik commented on DERBY-5253: -------------------------------------- Would it be a good idea to make a small Wiki write-up on current state/ best practices when it comes to the use of shared code? It's not obvious.. > Engine code references org.apache.derby.shared.common.sanity.SanityManager > -------------------------------------------------------------------------- > > Key: DERBY-5253 > URL: https://issues.apache.org/jira/browse/DERBY-5253 > Project: Derby > Issue Type: Bug > Components: Miscellaneous > Affects Versions: 10.9.0.0 > Reporter: Kristian Waagan > Assignee: Kristian Waagan > Priority: Minor > Fix For: 10.9.0.0 > > Attachments: derby-5253-1a-engine_imports.diff > > > Derby engine code is importing org.apache.derby.shared.common.sanity.SanityManager, causing sealing violations. See DERBY-4669 why this fix is inadequate. > Even though this won't fix the/all problems, using shared.common.sanity.SanityManager on the client and iapi.services.sanity.SanityManager in the engine code is a simple rule to follow. Violations are also easily addressed. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira