db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5156) convert store/longColumn.sql into junit test case
Date Thu, 02 Jun 2011 02:28:47 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042575#comment-13042575

Bryan Pendleton commented on DERBY-5156:

The patch looks very good to me. I have two thoughts:

1) In a few places, the test deliberately causes a failure, using code like:

        try {
            st.executeUpdate("create index zz on testing (a)");
            fail("try creating btree index on long column, should fail");
        } catch (SQLException e) {

It seems like it would be nice if the body of the "catch" statement verified
that we received the expected exception. That is, instead of "assertTrue(true)",
the test said something like assertSQLState("XSCB6", e);

2) I think that the existing test runs queries, and verifies not only that the
number of rows is correct, but also that the contents of the column values
that are returned by the SELECT statement match the expected results.
The new test appears to only check the number of rows returned. Is this
sufficient, for the purposes of this test? (for the other developers reading this,
please offer an opinion about whether this test will test the long column
behaviors adequately by checking the number of rows in the result set)

> convert store/longColumn.sql into junit test case
> -------------------------------------------------
>                 Key: DERBY-5156
>                 URL: https://issues.apache.org/jira/browse/DERBY-5156
>             Project: Derby
>          Issue Type: Task
>          Components: Test
>            Reporter: Houx Zhang
>            Assignee: Houx Zhang
>              Labels: gsoc2011
>         Attachments: DERBY-5156-1.patch, DERBY-5156-1.stat, DERBY-5156.patch
>   Original Estimate: 168h
>  Remaining Estimate: 168h

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message