db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DERBY-5293) Replace bubble sort in DataDictionaryImpl and CreateTriggerNode with Collections.sort()
Date Thu, 23 Jun 2011 09:15:27 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Knut Anders Hatlen updated DERBY-5293:
--------------------------------------

    Attachment: d5293.diff

Attaching patch that removes the manual sorting and uses Collections.sort() instead.

All the regression tests ran cleanly with the patch.

> Replace bubble sort in DataDictionaryImpl and CreateTriggerNode with Collections.sort()
> ---------------------------------------------------------------------------------------
>
>                 Key: DERBY-5293
>                 URL: https://issues.apache.org/jira/browse/DERBY-5293
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.9.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d5293.diff
>
>
> DataDictionaryImpl and CreateTriggerNode contain implementations of bubble sort that
could be replaced by calls to Collections.sort(). This isn't performance critical code (it's
only used for sorting vectors of column references or table nodes at compile time) so there
shouldn't be much to gain by hand-coding the sorting. Using Collections.sort() has the benefits
that it results in less code and that the implementation has probably gone through more testing
than our hand-coded one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message