db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5282) Convert store/RowLockBasic.sql to junit
Date Thu, 30 Jun 2011 06:32:28 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057643#comment-13057643
] 

Knut Anders Hatlen commented on DERBY-5282:
-------------------------------------------

A couple post-commit review comments:

- The new test should have a license header.

- We should probably remove the try/catch in the setUp() method. If something fails in setUp(),
it would be better if the test case failed. Failures that are just printed to the console
are less likely to be noticed.

- The tearDown() method should call super.tearDown() before it returns so that BaseJDBCTestCase's
cleanup also runs.

- Saving the original isolation level in setUp() and restoring it in tearDown() shouldn't
be necessary since the connection isn't used again after tearDown().

> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
>                 Key: DERBY-5282
>                 URL: https://issues.apache.org/jira/browse/DERBY-5282
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>            Reporter: Houx Zhang
>            Assignee: Houx Zhang
>              Labels: gsoc2011
>             Fix For: 10.9.0.0
>
>         Attachments: derby-5282-1.patch, derby-5282-1.state, derby-5282-2.patch, derby-5282-2.state
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message