db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5260) Remove unused "replace" argument to backup variant of StorageFactoryService#saveServiceProperties
Date Sat, 04 Jun 2011 18:40:47 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044353#comment-13044353
] 

Dag H. Wanvik commented on DERBY-5260:
--------------------------------------

Regrressions completed ok, modulo two diffs in dblook_test and dblook_test_territory:

The line:
java.io.FileNotFoundException: <filePath>
is missing from the *.out file. I can see it is present in the raw file before filtering,
not sure why it gone after filtering.
There was a bug in this earlier, cf. DERBY-266, but that one is closed.

In my case this piece if text is gone after filtering:

-- **--> DEBUG: Failed to load jar file /export/home/dag/java/sb/tests/saveServiceProperties-1-derbyall-1.6.0_24-sb.sb1.classes-19394/DBJARS/BAR/BARJAR.jar.G1307158346528
java.io.FileNotFoundException: /export/home/dag/java/sb/tests/saveServiceProperties-1-derbyall-1.6.0_24-sb.sb1.classes-19394/derbyall/derbytools/dblook_test/wombat/jar/BAR/BARJAR.jar.G1307158346528
(No such file or directory)
	at java.io.FileInputStream.open(Native Method)
	at java.io.FileInputStream.<init>(FileInputStream.java:106)
	at java.io.FileInputStream.<init>(FileInputStream.java:66)
	at org.apache.derby.impl.tools.dblook.DB_Jar.doJars(DB_Jar.java:104)
	at org.apache.derby.tools.dblook.go(dblook.java:533)
	at org.apache.derby.tools.dblook.<init>(dblook.java:142)
	at org.apache.derbyTesting.functionTests.tests.tools.dblook_test.go(dblook_test.java:574)
	at org.apache.derbyTesting.functionTests.tests.tools.dblook_test.runMessageCheckTest(dblook_test.java:679)
	at org.apache.derbyTesting.functionTests.tests.tools.dblook_test.doTest(dblook_test.java:106)
	at org.apache.derbyTesting.functionTests.tests.tools.dblook_test.main(dblook_test.java:83)

So, as can be seen, the line "java.io.FileNotFoundException" is
present, but is gone after filtering away the stack trace.  The
directory *does* have "derby" in it, cf. the subdirectory
"derbyall". Maybe DERBY-266 didnt do a through enough job in fixing
this issue....

In any case, I believe is discrepancy unrelated to the change in this issue.




> Remove unused "replace" argument to backup variant of StorageFactoryService#saveServiceProperties
> -------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-5260
>                 URL: https://issues.apache.org/jira/browse/DERBY-5260
>             Project: Derby
>          Issue Type: Improvement
>          Components: Services
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>            Priority: Minor
>         Attachments: saveServiceProperties-1.diff, saveServiceProperties-1.stat
>
>
> This variant of the method is never called with replace == true, so the code to handle
replacement can be removed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message