Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Date: Wed, 11 May 2011 23:05:47 +0000 (UTC)
From: "Dave Brosius (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Message-ID: <42955408.5302.1305155147958.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <654799318.555.1305046727366.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (DERBY-5224) [patch] reduce cohesion by removing
 overzealous casting
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032163#comment-13032163 ] 

Dave Brosius commented on DERBY-5224:
-------------------------------------

Do what you like of course, but if that is the case, it would seem to me that prnRSN in your example should be defined as a RowCountNode then.

> [patch] reduce cohesion by removing overzealous casting
> -------------------------------------------------------
>
>                 Key: DERBY-5224
>                 URL: https://issues.apache.org/jira/browse/DERBY-5224
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Dave Brosius
>            Priority: Trivial
>         Attachments: reduce_cohesion.diff
>
>
> various spots casts assignments to a type more restrictive than needed, increasing cohesion. Patch reduces the casting to the required types.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira