From derby-dev-return-88003-apmail-db-derby-dev-archive=db.apache.org@db.apache.org Sun May 29 20:02:32 2011 Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 896134F05 for ; Sun, 29 May 2011 20:02:32 +0000 (UTC) Received: (qmail 54345 invoked by uid 500); 29 May 2011 20:02:32 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 54327 invoked by uid 500); 29 May 2011 20:02:32 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 54320 invoked by uid 99); 29 May 2011 20:02:32 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 29 May 2011 20:02:32 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 29 May 2011 20:02:30 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 549DBE7F0B for ; Sun, 29 May 2011 20:01:49 +0000 (UTC) Date: Sun, 29 May 2011 20:01:49 +0000 (UTC) From: "Bryan Pendleton (JIRA)" To: derby-dev@db.apache.org Message-ID: <81611286.52226.1306699309343.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1739756600.15027.1301227025729.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (DERBY-5156) convert store/longColumn.sql into junit test case MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040865#comment-13040865 ] Bryan Pendleton commented on DERBY-5156: ---------------------------------------- The patch looks good to me; the new test is nice and clear. I like the way you segmented the testing into separate logical tests to match the original SQL test's structure, thanks. When you contribute a patch which contains added and/or deleted files, it is convenient if you can also include the output of 'svn stat' so it is obvious which files are to be added and/or deleted, as that can be hard to tell sometimes just from reading the patch. Should the patch also delete derbyTesting/functionTests/master/longColumn.out? It looks like that might be missing from the patch. > convert store/longColumn.sql into junit test case > ------------------------------------------------- > > Key: DERBY-5156 > URL: https://issues.apache.org/jira/browse/DERBY-5156 > Project: Derby > Issue Type: Task > Components: Test > Reporter: Houx Zhang > Assignee: Houx Zhang > Labels: gsoc2011 > Attachments: DERBY-5156.patch > > Original Estimate: 168h > Remaining Estimate: 168h > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira