db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5156) convert store/longColumn.sql into junit test case
Date Sun, 29 May 2011 20:01:49 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040865#comment-13040865
] 

Bryan Pendleton commented on DERBY-5156:
----------------------------------------

The patch looks good to me; the new test is nice and clear. I like the way
you segmented the testing into separate logical tests to match the original
SQL test's structure, thanks.

When you contribute a patch which contains added and/or deleted files, it
is convenient if you can also include the output of 'svn stat' so it is obvious
which files are to be added and/or deleted, as that can be hard to tell sometimes
just from reading the patch.

Should the patch also delete derbyTesting/functionTests/master/longColumn.out? It
looks like that might be missing from the patch.


> convert store/longColumn.sql into junit test case
> -------------------------------------------------
>
>                 Key: DERBY-5156
>                 URL: https://issues.apache.org/jira/browse/DERBY-5156
>             Project: Derby
>          Issue Type: Task
>          Components: Test
>            Reporter: Houx Zhang
>            Assignee: Houx Zhang
>              Labels: gsoc2011
>         Attachments: DERBY-5156.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message