db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5224) [patch] reduce cohesion by removing overzealous casting
Date Thu, 12 May 2011 00:18:47 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032197#comment-13032197
] 

Dag H. Wanvik commented on DERBY-5224:
--------------------------------------

I checked again, and I see that the pattern I referred to isn't always used at all: For example
in SelectNode, ca 30% of node creations do *not* use the pattern. So, I'm ok with the change.


> [patch] reduce cohesion by removing overzealous casting
> -------------------------------------------------------
>
>                 Key: DERBY-5224
>                 URL: https://issues.apache.org/jira/browse/DERBY-5224
>             Project: Derby
>          Issue Type: Improvement
>            Reporter: Dave Brosius
>            Priority: Trivial
>         Attachments: reduce_cohesion.diff
>
>
> various spots casts assignments to a type more restrictive than needed, increasing cohesion.
Patch reduces the casting to the required types.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message