db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tiago R. Espinha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5014) Tests should restore the timeout values to default after they are done running.
Date Tue, 31 May 2011 18:28:47 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041731#comment-13041731
] 

Tiago R. Espinha commented on DERBY-5014:
-----------------------------------------

Hi Siddharth,

It seems like the patch has passed but I have a few questions/remarks about the patch.

1) As mentioned before, please avoid whitespace changes. In this patch, we're patching DatabasePropertyTestSetup.java
unnecessarily.

2) Why do we need to import java.util.Properties into ResultSetsFromPreparedStatementTest.java?

In the end, is SysinfoTest.java the only one that needs to be changed? If so and if no one
else objects, I'm going to change the patch to remove the unnecessary chunks and commit it.

I should also mention (and Siddharth, in the future it's also good practice to do so on JIRA
upon posting a patch) that regressions were ran (suites.All) for this patch and it succeeded
without any failures.

--

As for what you mentioned about creating a test to check whether the default values have been
reset, I think that can be very difficult. The main challenge is: *when* do you run this test?
Would you run it after every single test in JUnit? That would be incredibly time consuming.

Since these are just tests, we usually just trust that: if suites.All passes, then all the
values are being reset, or if they aren't, it's not serious enough that it is not making the
whole suite collapse.

> Tests should restore the timeout values to default after they are done running.
> -------------------------------------------------------------------------------
>
>                 Key: DERBY-5014
>                 URL: https://issues.apache.org/jira/browse/DERBY-5014
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.7.1.1
>            Reporter: Mamta A. Satoor
>            Assignee: Siddharth Srivastava
>              Labels: derby_triage10_8
>         Attachments: d5014_1.diff
>
>
> There are still couple more tests that change the lock time out during the test run but
don't restore it to the default at the
> end of the test. Knut already fixed this behavior for SetTransactionIsolationTest.java
and ResultSetMiscTest.java as part of DERBY-4273 
> Following are some additional tests that should be fixed 
> 1)ErrorMessageTest.java 2)StressMultiTest.java 3)Sttest.java 4)SysinfoTest.java 5)DatabaseMetaDataTest.java
6)ResultSetsFromPreparedStatementTest.java

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message