db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dag H. Wanvik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5210) Use java.nio.ByteBuffer in client.net.Request
Date Thu, 05 May 2011 19:23:03 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029518#comment-13029518
] 

Dag H. Wanvik commented on DERBY-5210:
--------------------------------------

Thanks for this cleanup! Nice to see so much bit-tweaking go away. In spite of the slight
CPU increase of this patch in isolation, you say that with changes planned in DERBY-5068 which
reply on this change if I understand correctly, CPU usage will go down again, so on that basis
also, I am positive to this change: +1

> Use java.nio.ByteBuffer in client.net.Request
> ---------------------------------------------
>
>                 Key: DERBY-5210
>                 URL: https://issues.apache.org/jira/browse/DERBY-5210
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.9.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>         Attachments: d5210-1a.diff
>
>
> We should see if we could use a java.nio.ByteBuffer instead of a byte array in org.apache.derby.client.net.Request,
similar to what we did for DDMWriter in DERBY-2936. ByteBuffer provides some helper methods
that allows us to simplify the code that puts multi-byte values into the buffer (like ByteBuffer.putShort(),
putInt(), putLong()). It may also be a first step on the way to using a CharsetEncoder to
encode strings without going via an intermediate throw-away byte array (see DERBY-5068 for
details).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message