Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 6103 invoked from network); 4 Apr 2011 16:44:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 4 Apr 2011 16:44:44 -0000 Received: (qmail 83389 invoked by uid 500); 4 Apr 2011 16:44:43 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 83368 invoked by uid 500); 4 Apr 2011 16:44:43 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 83361 invoked by uid 99); 4 Apr 2011 16:44:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Apr 2011 16:44:43 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Apr 2011 16:44:42 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id B089D92EA2 for ; Mon, 4 Apr 2011 16:44:05 +0000 (UTC) Date: Mon, 4 Apr 2011 16:44:05 +0000 (UTC) From: "Kathey Marsden (JIRA)" To: derby-dev@db.apache.org Message-ID: <2052984713.32780.1301935445719.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <290931845.15263.1299916559640.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (DERBY-5127) Convert madhare.sql to JUnit MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DERBY-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015492#comment-13015492 ] Kathey Marsden commented on DERBY-5127: --------------------------------------- You are absolutely right. I guess I got wrapped up in the minutia in the review and missed this major point. Siddharth can you submit a new patch using org.apache.derbyTesting.junit.JDBC.assertFullResultSet() to verify the results? You can see sample usage in lang.SimpleTest and other tests. If the ResultSet is big I sometimes use org.apache.derbyTesting.junit.showResultSet() temporarily to print out the array to feed to assertFullResultSet(). > Convert madhare.sql to JUnit > ---------------------------- > > Key: DERBY-5127 > URL: https://issues.apache.org/jira/browse/DERBY-5127 > Project: Derby > Issue Type: Improvement > Components: Test > Reporter: Siddharth Srivastava > Assignee: Siddharth Srivastava > Priority: Minor > Attachments: d5127.diff, derby5127(2).diff, derby5127.diff, derby5127.diff, derby5127.diff, derby5127.diff > > > Convert madhare.sql to JUnit -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira