From derby-dev-return-87366-apmail-db-derby-dev-archive=db.apache.org@db.apache.org Wed Apr 27 03:30:49 2011 Return-Path: X-Original-To: apmail-db-derby-dev-archive@www.apache.org Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9A240267A for ; Wed, 27 Apr 2011 03:30:49 +0000 (UTC) Received: (qmail 18851 invoked by uid 500); 27 Apr 2011 03:30:49 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 18764 invoked by uid 500); 27 Apr 2011 03:30:48 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 18578 invoked by uid 99); 27 Apr 2011 03:30:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Apr 2011 03:30:45 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Apr 2011 03:30:42 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id C54A6B5C52 for ; Wed, 27 Apr 2011 03:30:03 +0000 (UTC) Date: Wed, 27 Apr 2011 03:30:03 +0000 (UTC) From: "Bryan Pendleton (JIRA)" To: derby-dev@db.apache.org Message-ID: <654774105.4965.1303875003804.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (DERBY-4443) Wrap rollback in exception handlers in try-catch MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025584#comment-13025584 ] Bryan Pendleton commented on DERBY-4443: ---------------------------------------- Thank you Houx for the update. I understand about the tests; they take a very long time for me, too. I am hoping to set up a faster machine for running the tests sometime over the summer, but for now I am like you, it is quite hard to run the tests. So I don't run the full suite very often, but I do like to run it on a patch whenever I can. I am going to move ahead with committing patch 7. > Wrap rollback in exception handlers in try-catch > ------------------------------------------------ > > Key: DERBY-4443 > URL: https://issues.apache.org/jira/browse/DERBY-4443 > Project: Derby > Issue Type: Bug > Components: Demos/Scripts, Documentation, Eclipse Plug-in, JDBC, Network Client, Network Server, Replication, Services, SQL, Test, Tools > Affects Versions: 10.5.3.0 > Reporter: Aaron Digulla > Assignee: Houx Zhang > Labels: derby_triage10_8 > Attachments: DERBY-4443-1.patch, DERBY-4443-2.patch, DERBY-4443-3.patch, DERBY-4443-4.patch, DERBY-4443-4.png, DERBY-4443-5.patch, DERBY-4443-6-tmp.patch, DERBY-4443.patch, derby-4443-7.patch > > > Avoid this pattern everywhere: > }catch(SQLException se){ > //issue a rollback on any errors > conn.rollback(); > throw se; > } > because an error in rollback will shadow the original exception. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira