db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jayaram Subramanian <rsjay1...@gmail.com>
Subject Re: (DERBY-5010) [patch] bad equivalence check
Date Fri, 15 Apr 2011 11:46:53 GMT
Modified the isEquivalent method to throw an exception like this.. is
it correct..

protected boolean isEquivalent(ValueNode o) throws StandardException
		if (isSameNodeType(o))
			BaseColumnNode other = (BaseColumnNode)o;
			return other.tableName.equals(other.tableName)
			&& other.columnName.equals(columnName);
		if (1==1) {	
			throw StandardException.newException("Exception in equivalent for test");
		return false;

Also  all of a sudden i started getting
1) TriggerTests:embeddedjava.sql.SQLException: No suitable driver
	at java.sql.DriverManager.getConnection(DriverManager.java:330)
	at java.sql.DriverManager.getConnection(DriverManager.java:297)
	at org.apache.derbyTesting.junit.DriverManagerConnector.openConnection(DriverManagerConnector.java:81)
	at org.apache.derbyTesting.junit.DriverManagerConnector.openConnection(DriverManagerConnector.java:43)
	at org.apache.derbyTesting.junit.TestConfiguration.openDefaultConnection(TestConfiguration.java:1538)

With Regards

On Thu, Apr 14, 2011 at 4:57 AM, Knut Anders Hatlen
<knut.hatlen@oracle.com> wrote:
> Jayaram Subramanian <rsjay1976@gmail.com> writes:
>> Hi Knut,
>> Sorry for the delay.. It was hectic for me for the past 2 months..
>> When i placed thread.dumpstack and ran the lang.__suite, the log shows
>> a lot of references to isEquivalent method..  Just attaching one of
>> the example. Could you please guide me how to proceed from here
> Hi Jayaram,
> This sounds like good progress. Now you know which tests that call this
> method. I think the next step would be to find out what the queries look
> like. Can you see that from the test logs? If not, maybe you can make
> the method throw an exception so that the test stops once the method is
> called. If we know what the queries look like, we may find a way to
> tweak them so that they trigger the bug.
> --
> Knut Anders

View raw message