db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (DERBY-5084) convert ijConnName.sql to a ScriptTest junit test
Date Thu, 28 Apr 2011 14:27:04 GMT

     [ https://issues.apache.org/jira/browse/DERBY-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Myrna van Lunteren closed DERBY-5084.

          Resolution: Fixed
       Fix Version/s:
    Issue & fix info:   (was: [Patch Available])

I committed patch -9 to trunk with revision 1097460, with 2 minor modifications:
- this test - because there is no pre-decided use of client or embedded driver - will cause
java.sql.Driver to be invoked, which isn't available with JSR169. So I added a section at
the top of the suite method:
          if (JDBC.vmSupportsJSR169())
            return new TestSuite("empty: no support for Driver.sql.Manager with jsr 169");
- I changed the name of the method that does the actual asserts from 'testConnectWrongSubprotocol'
to 'checkConnectWrongSubprotocol'. I find it easier to identify the fixtures when they start
with 'test' when I look at the code. But this was more a personal preference, no technical

Then I noticed that we missed adding the apache licence header to IjConnNameTest and the new
test, and added them to trunk with revision  1097469.
(Then I realized I forgot to change the name after cut-and-paste in one of the headers and
fixed that up with reivision 1097471).

I backported these changed to 10.8 with revision 1097477.

Thank you for your work on this issue!

> convert ijConnName.sql to a ScriptTest junit test
> -------------------------------------------------
>                 Key: DERBY-5084
>                 URL: https://issues.apache.org/jira/browse/DERBY-5084
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Myrna van Lunteren
>            Assignee: Houx Zhang
>            Priority: Trivial
>              Labels: derby_triage10_8
>             Fix For:,
>         Attachments: DERBY-5084-1.patch, DERBY-5084-2.patch, DERBY-5084-3.patch, DERBY-5084-3.stat,
DERBY-5084-9.patch, DERBY-5084.patch, DERBY-5084_4.diff, DERBY-5084_5.diff, derby-5084-6.patch,
derby-5084-7.patch, derby-5084-8.patch, ijConnName-1.out, ijConnName-1.tmp
> In DERBY-3089 it is mentioned that tools/ijConnName.sql should get converted to a junit
test, probably using ScriptTest.
> Making a separate issue so that that issue can be closed.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message