db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5084) convert ijConnName.sql to a ScriptTest junit test
Date Fri, 22 Apr 2011 03:27:05 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023092#comment-13023092
] 

Myrna van Lunteren commented on DERBY-5084:
-------------------------------------------

I agree Bryan. I had made a similar comment - but my session had expired. :-)

I think on the whole the patch looks good, I have just 2 comments:

1. You cannot use contains(String). This only works as of java 1.5; if you compile with 1.4.2
libraries, you'd get the build error Bryan described.
We support jvm 1.4.2, so you cannot use this construct unless the class is explicitly getting
built with 1.5 or higher (see the tools/build.xml; you can see source and target are defined
as 1.4). 
To prevent this kind of issue with your patches, you should obtain a 1.4.2 jre, see trunk/<BUILDING.html>.

There's also been discussions on this in the past, you can search the list archives. I think
typically we use a construct like: assertTrue((ijResult.indexOf("08001")>1);

2. As there is no protocol specified, there's no point running this test with both embedded
and client, the only thing it would do with client is starting and shutting down NetworkServer
for no reason. I suggest you use EmbeddedSuite() instead of defaultSuite().

Did you run suites.All? You didn't say...


> convert ijConnName.sql to a ScriptTest junit test
> -------------------------------------------------
>
>                 Key: DERBY-5084
>                 URL: https://issues.apache.org/jira/browse/DERBY-5084
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Myrna van Lunteren
>            Assignee: Houx Zhang
>            Priority: Trivial
>              Labels: derby_triage10_8
>         Attachments: DERBY-5084-1.patch, DERBY-5084-2.patch, DERBY-5084-3.patch, DERBY-5084-3.stat,
DERBY-5084.patch, DERBY-5084_4.diff, DERBY-5084_5.diff, derby-5084-6.patch, ijConnName-1.out,
ijConnName-1.tmp
>
>
> In DERBY-3089 it is mentioned that tools/ijConnName.sql should get converted to a junit
test, probably using ScriptTest.
> Making a separate issue so that that issue can be closed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message