db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DERBY-5084) convert ijConnName.sql to a ScriptTest junit test
Date Wed, 27 Apr 2011 04:29:03 GMT

    [ https://issues.apache.org/jira/browse/DERBY-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025599#comment-13025599

Myrna van Lunteren commented on DERBY-5084:

There's indeed no need to run the full suites.All for such a small test as with this patch.

I took a look at your new patch, and find I didn't check the first patch (-6.patch) properly,
I apologize for that. 

I don't think the new test is doing the same thing as the original test. The original test
was setting the connection with the bad subprotocol ('jdbc:noone:', it should be jdbc:derby,
of course) using an ij property. The new test is using a simple ij connect statement with
a bad subprotocol. 

I did a simple 'grep' and didn't find another test where a bad subprotocol was lobbed at ij...(jdbcapi/DriverTest
and management.JDBCMBeanTest do test incorrect subprotocol). So I guess this test does test
something useful, but it's not the same as the original test. 

Also, but that's more of a nit, the name is not really right, because we're not even specifying
a driver, just a bad subprotocol (which results in derby not finding any driver to use). 

Can you add the testing of passing in the bad subprotocol with a system property? 

> convert ijConnName.sql to a ScriptTest junit test
> -------------------------------------------------
>                 Key: DERBY-5084
>                 URL: https://issues.apache.org/jira/browse/DERBY-5084
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Myrna van Lunteren
>            Assignee: Houx Zhang
>            Priority: Trivial
>              Labels: derby_triage10_8
>         Attachments: DERBY-5084-1.patch, DERBY-5084-2.patch, DERBY-5084-3.patch, DERBY-5084-3.stat,
DERBY-5084.patch, DERBY-5084_4.diff, DERBY-5084_5.diff, derby-5084-6.patch, derby-5084-7.patch,
ijConnName-1.out, ijConnName-1.tmp
> In DERBY-3089 it is mentioned that tools/ijConnName.sql should get converted to a junit
test, probably using ScriptTest.
> Making a separate issue so that that issue can be closed.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message