db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (DERBY-4260) Make derbynet/NetworkServerControlClientCommandTest run regardless of the locale
Date Wed, 20 Apr 2011 01:01:11 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bryan Pendleton resolved DERBY-4260.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 10.9.0.0

Yes, I think this patch is ready to commit.

Committed to the trunk as revision 1095247.

Thanks for the contribution to Derby!


> Make derbynet/NetworkServerControlClientCommandTest run regardless of the locale
> --------------------------------------------------------------------------------
>
>                 Key: DERBY-4260
>                 URL: https://issues.apache.org/jira/browse/DERBY-4260
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.6.1.0
>            Reporter: Tiago R. Espinha
>            Assignee: Houx Zhang
>            Priority: Minor
>              Labels: gsoc, gsoc2011
>             Fix For: 10.9.0.0
>
>         Attachments: 4260-1.patch
>
>
> The NetworkServerControlClientCommandTest has in it a check that will only run the test
if the locale is set to 'en'.
> It is open to suggestion the how to achieve this and whether it should be done. Since
the test is a pretty generic one, I think it should be ran regardless of the locale.
> Knut suggested we'd force the locale to 'en' on the setUp() and back to its previous
value on the tearDown(). On a first analysis this seems like the ideal method to go about
it. Just removing the check for the locale altogether might not be wise because of the calls
to assertFailedPing() that involve some hardcoded strings.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message